PR_26179_OWNER_036-reports-are-tracked-source#280
Conversation
There was a problem hiding this comment.
💡 Codex Review
HTML-JavaScript-Gaming/dev/reports/codex_review.diff
Lines 9 to 11 in ca8af9e
This committed codex_review.diff is stale: it records an earlier draft adding ## Tracked Report Governance, while the actual committed document now adds ## Codex Reports with different wording. Since this PR also makes dev/reports/ the official report record, keeping a review artifact that does not match the committed change will mislead future audit/review workflows that rely on these tracked reports.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - If OWNER decision is required, stop and report. | ||
| - Every PR lifecycle state must satisfy the Codex Completion Contract when Codex executes work for that state. | ||
| - ZIP artifacts belong under `dev/workspace/zips/` and must not replace required reports under `dev/reports/`. | ||
| - Reports generated during a PR are expected to be committed as part of that PR. Do not delete report files solely to obtain a clean worktree, and do not add `dev/reports/` to `.gitignore`. |
There was a problem hiding this comment.
Clarify how post-merge reports get committed
When APPLY_PR/post-merge closeout generates required reports after the PR has already been merged and the runner is back on main, this rule leaves no valid path to close the same PR: the new reports cannot be committed “as part of that PR”, while direct commits to main are prohibited unless OWNER explicitly approves. That makes post-merge closeout runs either leave dev/reports/ dirty or require an undocumented follow-up PR, so the workflow should explicitly exempt/route post-merge closeout reports.
Useful? React with 👍 / 👎.
ca8af9e to
449bccf
Compare
449bccf to
2922ed0
Compare
PR_26179_OWNER_036-reports-are-tracked-source
Summary
This governance PR clarifies that
dev/reports/contains the authoritative Codex reports for the repository and that reports committed tomainare the official record. Reports generated during a PR are expected to be committed as part of that PR, while repository authority remains the report state committed tomain.Scope
dev/reports/..gitignorechanges.Policy Added
dev/reports/contains the authoritative Codex reports for the repository.mainare the official record.main, those report versions become the canonical repository history.dev/reports/to.gitignore.dev/workspace/zips/.Validation
PASS:
git diff --checknpm run validate:canonical-structure