Skip to content

PR_26179_CHARLIE_040-dev-artifact-location-cleanup#281

Merged
ToolboxAid merged 1 commit into
mainfrom
PR_26179_CHARLIE_040-dev-artifact-location-cleanup
Jun 28, 2026
Merged

PR_26179_CHARLIE_040-dev-artifact-location-cleanup#281
ToolboxAid merged 1 commit into
mainfrom
PR_26179_CHARLIE_040-dev-artifact-location-cleanup

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

  • Move generated Charlie Sprite Editor PR reports from legacy docs_build/dev/reports/ into canonical dev/reports/.
  • Remove legacy tracked Codex report aliases under docs_build/dev/reports/ and regenerate canonical dev/reports/codex_changed_files.txt and dev/reports/codex_review.diff.
  • Update Charlie Sprite report references from dev/workspace/zip/ to canonical dev/workspace/zips/.

Validation

  • PASS: Batch governance and canonical artifact Project Instructions reviewed.
  • PASS: Legacy-path scan over moved PR 022-039 reports returned no matches.
  • PASS: Changed-file scope is generated reports/artifact cleanup only.
  • PASS: git diff --cached --check returned no whitespace errors before commit.
  • PASS: Repo-structured ZIP created at dev/workspace/zips/PR_26179_CHARLIE_040-dev-artifact-location-cleanup_delta.zip.

Notes

  • No runtime behavior, Sprite Editor functionality, DB/API/schema, or start_of_day files changed.
  • Unrelated untracked docs_build/dev/reports/sprite-history-inventory.md was left untouched.

@ToolboxAid ToolboxAid marked this pull request as ready for review June 28, 2026 20:21
@ToolboxAid ToolboxAid changed the base branch from PR_26179_CHARLIE_039-sprites-color-and-zoom-fix to main June 28, 2026 20:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ea325839a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

| Produce recommendation report only | PASS | Report-only governance deliverable. |
| Use canonical report location | PASS | Reports are under `dev/reports/`. |
| Produce outcome ZIP | PASS | ZIP to be generated under `dev/workspace/zips/`. |
diff --git a/docs_build/dev/reports/PR_26179_CHARLIE_022-sprites-tool-shell.md b/dev/reports/PR_26179_CHARLIE_022-sprites-tool-shell.md

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the BOM from the generated diff

The new codex_review.diff starts with a UTF-8 BOM before the first diff --git header. Checked against the parent tree, git apply --check dev/reports/codex_review.diff fails on the first rename, while the same file with only the BOM stripped applies cleanly; this makes the generated diff artifact unusable for anyone applying or validating the packaged delta.

Useful? React with 👍 / 👎.

@ToolboxAid ToolboxAid force-pushed the PR_26179_CHARLIE_040-dev-artifact-location-cleanup branch from 0ea3258 to e29ac38 Compare June 28, 2026 20:29
@ToolboxAid ToolboxAid merged commit b3a2b30 into main Jun 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant