Add drag-and-drop plugin validation to the main window#170
Open
jcredland wants to merge 1 commit into
Open
Conversation
Drop a .vst3/.vst/.component/.dll/.so/.clap onto the pluginval window to validate it. Shows a highlighted overlay during the drag and routes through Validator::validate — the same flow used by "Test File...".
Collaborator
|
Thanks for this! I QA'd this and looked through it. The prior behavior is that a drag would add a plugin to the list (vs. run validation). It was the main way I added plugins (dropping them in from finder). I do think that still makes sense to add, even though it's also useful that it starts a run. We could do both with a change like this: 6ec3eb6 The other thing is that with the run-on-drop behavior, I can reliably beachball pluginval by dropping a plugin in there while another is scanning. Something like this would fix: c7b155a Otherwise looks and works great, happy to merge with my commits as followups or wait for changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.vst3/.vst/.component/.dll/.so/.clapanywhere on the pluginval window to validate it.Validator::validate(StringArray, options)— the same flow used by Test File…, so it picks up the current strictness level, timeout, sample rates, etc. Console tab is auto-activated when validation starts (existing behaviour).Test plan
.vst3onto the window — highlight appears, drop starts validation..txt) — no highlight, drop is ignored.validatecall.