Integrate all data variables in UxDataset.integrate()#1531
Open
rajeeja wants to merge 4 commits into
Open
Conversation
UxDataset.integrate() now integrates every grid-mapped data variable via UxDataArray.integrate() and returns a new UxDataset, replacing the previous first-variable-only behavior and its deprecation warning. Variables not mapped to the grid are skipped with a warning. Closes #463
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
UxDataset.integrate()integrate every grid-mapped data variable (viaUxDataArray.integrate()) and return a newUxDataset, replacing the old first-variable-only behavior and its deprecation warning. Non-grid variables are skipped with a warning.Breaking change: return type is now a
UxDataset(was a scalar).Includes tests and a short showcase in the area-calc user guide.
Closes #463