feat(analyzers): validate TypeSelector string arguments (AFT0006-AFT0008)#139
Merged
VPDPersonal merged 2 commits intoJul 7, 2026
Merged
Conversation
…008) - bump analyzers submodule to the AFT0006-AFT0008 branch and redeploy the analyzer DLL into the package - AFT0006/AFT0007 (error): identifier strings must name a readable instance member; AFT0008 (warning): malformed assembly-qualified names - add QA-checklist items for the three rules in EN and RU Co-Authored-By: Claude <noreply@anthropic.com>
VPDPersonal
added
type: feature
Co-Authored-By: Claude <noreply@anthropic.com>
VPDPersonal
added
status: needs-review
VPDPersonal
deleted the
feat/asp-56-validate-typeselector-string-arguments
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AFT0006/AFT0007(error),AFT0008(warning): compile-time validation of[TypeSelector("...")]string arguments — an identifier string must name a readable instance member (Type/Type[]/string/string[]), any other string must be a plausible assembly-qualified type nameAspid.FastTools.Analyzers.dllinto the packageNotes for review
[TypeSelector]string arguments member-first (TypeSelectorPropertyDrawer.GetTypesFromAttribute); today a typo silently drops the constraint — these rules surface it at compile time instead.Linked issues
Closes ASP-56
🇷🇺 Описание на русском
Кратко
AFT0006/AFT0007(error),AFT0008(warning): compile-time валидация строковых аргументов[TypeSelector("...")]— строка-идентификатор обязана называть читаемый instance-член (Type/Type[]/string/string[]), любая другая строка — правдоподобное assembly-qualified имя типаAspid.FastTools.Analyzers.dllпереразвёрнута в пакетЗамечания для ревью
[TypeSelector]member-first (TypeSelectorPropertyDrawer.GetTypesFromAttribute); сегодня опечатка молча снимает ограничение — правила выносят это на этап компиляции.