Fix refinalization for --gufa-cast-all#8773
Open
tlively wants to merge 1 commit into
Open
Conversation
In #8747 we refactored GUFA's `replaceCurrent` to set `optimized = true` and removed the now-redundant `optimized = true` at all the call sites. But we were too aggressive and removed an `optimized = true` in `Adder`, which had a separate `replaceCurrent` that did not set `optimized = true`. This caused a regression where we no longer refinalized after adding casts, but the regression was not caught by any tests. Fix the bug and add a test that depends on refinalization after adding casts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #8747 we refactored GUFA's
replaceCurrentto setoptimized = trueand removed the now-redundantoptimized = trueat all the call sites. But we were too aggressive and removed anoptimized = trueinAdder, which had a separatereplaceCurrentthat did not setoptimized = true. This caused a regression where we no longer refinalized after adding casts, but the regression was not caught by any tests.Fix the bug and add a test that depends on refinalization after adding casts.