fix: MSSQL varchar/varbinary MAX size and Column attribute name#165
Merged
Conversation
…eter - Fix #163: Accept size -1 in MSSQLColumn::setSize() for MAX-capable types (varchar, nvarchar, varbinary) and output 'max' in generated SQL - Fix #159: Use explicit 'name' from #[Column] attribute for property-level columns instead of always deriving from propertyToKey() Closes #163 Closes #159
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two confirmed bugs: MSSQL MAX column size and Column attribute name being ignored.
Motivation
varbinary(max)columns results invarbinary(1)becausesetSize(-1)is rejected#[Column(name: 'created_at')]on properties producescreated-atinstead ofcreated_atChanges
Column::setSize()— accept-1as valid (for MAX semantics)MSSQLColumn::setSize()— allow-1for varchar, nvarchar, varbinaryMSSQLColumn::firstColPartString()— outputmaxwhen size is -1AttributeTableBuilder— use explicitnamefrom#[Column]attribute when provided for property-level columnsBugVerificationTestcovering all three issues (bug(MSSQLColumn): varbinary/varchar MAX size (-1) creates column with size 1 instead of MAX #163, bug: Column attribute 'name' parameter is ignored during table creation #159, AttributeTableBuilder does not create UNIQUE constraints for MSSQL columns #153)How to Test / Verify
Full suite passes (882 tests).
Breaking Changes and Migration Steps
None. Schemas without explicit
namein#[Column]continue usingpropertyToKey().Checklist
Related issues
Closes #163
Closes #159