Skip to content

fix: stale query bindings, MSSQL MAX size, and Column attribute name#166

Merged
usernane merged 2 commits into
mainfrom
dev
Jun 8, 2026
Merged

fix: stale query bindings, MSSQL MAX size, and Column attribute name#166
usernane merged 2 commits into
mainfrom
dev

Conversation

@usernane

@usernane usernane commented Jun 8, 2026

Copy link
Copy Markdown
Member

Summary

Merge dev into main with three bug fixes and observability improvements.

Motivation

  • MSSQL error 245 (varchar to int conversion) when migrations fail before execute()
  • varbinary(max) / varchar(max) columns created as size 1 on MSSQL
  • #[Column(name: 'created_at')] attribute name parameter ignored for property-level columns

Changes

How to Test / Verify

composer test

Full suite: 882 tests, 2535 assertions, all passing.

Breaking Changes and Migration Steps

None

Checklist

  • I reviewed my own diff before requesting review
  • My commits follow Conventional Commits
  • The title of the pull request follows Conventional Commits
  • I added/updated tests (or explained why not)
  • I updated docs (if needed)
  • I ran lint/cs-fixer (if applicable)
  • I considered backward compatibility
  • I considered security

Related issues

Closes #163
Closes #159

Ibrahim BinAlshikh and others added 2 commits June 8, 2026 22:43
…eter

- Fix #163: Accept size -1 in MSSQLColumn::setSize() for MAX-capable
  types (varchar, nvarchar, varbinary) and output 'max' in generated SQL
- Fix #159: Use explicit 'name' from #[Column] attribute for property-level
  columns instead of always deriving from propertyToKey()

Closes #163
Closes #159
…column-name

fix: MSSQL varchar/varbinary MAX size and Column attribute name
@usernane usernane merged commit d0c7d63 into main Jun 8, 2026
3 of 5 checks passed
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant