Skip to content

Upgrade/Install: Remove accidentally shipped RTC files on upgrade#11959

Open
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/65325
Open

Upgrade/Install: Remove accidentally shipped RTC files on upgrade#11959
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/65325

Conversation

@itzmekhokan
Copy link
Copy Markdown

Summary

  • Adds real-time collaboration files to the $_old_files array in update-core.php so they are removed during core upgrades.
  • Addresses #65325, where RTC files removed in [62334] were unintentionally included in the WordPress 7.0 release package due to a build server issue.
  • The existing verify:old-files Grunt task will also fail builds if these files are present in the build/ directory, preventing recurrence.

Context

Real-time collaboration was removed from core in #65205 (62334, 62337, 62338 on the 7.0 branch). However, the files still shipped in wordpress-7.0.zip and the WordPress/WordPress 7.0 tag. The impact is mostly benign since the files are not loaded, but they should be cleaned up on upgrade and excluded from future builds.

Test plan

  • Verify php -l src/wp-admin/includes/update-core.php passes
  • Verify PHPCS reports no errors on the changed file
  • Confirm build/wp-includes/collaboration/ does not exist locally
  • Run npx grunt verify:old-files as part of a full build in CI
  • Confirm upgrading from a 7.0.0 install with RTC files to 7.0.1 removes:
    • wp-includes/collaboration.php
    • wp-includes/collaboration/class-wp-http-polling-sync-server.php
    • wp-includes/collaboration/class-wp-sync-post-meta-storage.php
    • wp-includes/collaboration/interface-wp-sync-storage.php

Backport

This change should be backported to the 7.0 branch for the 7.0.1 milestone.

Trac ticket: https://core.trac.wordpress.org/ticket/65325

Add real-time collaboration files to the `$_old_files` array so they are
removed when upgrading to 7.0.1. These files were removed in [62334] but
unintentionally shipped in the WordPress 7.0 package due to a build server
issue. The `verify:old-files` build check will also prevent them from being
included in future builds.

Props johnbillion, peterwilsoncc.
Fixes #65325.
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant