Upgrade/Install: Remove accidentally shipped RTC files on upgrade#11959
Upgrade/Install: Remove accidentally shipped RTC files on upgrade#11959itzmekhokan wants to merge 1 commit into
Conversation
Add real-time collaboration files to the `$_old_files` array so they are removed when upgrading to 7.0.1. These files were removed in [62334] but unintentionally shipped in the WordPress 7.0 package due to a build server issue. The `verify:old-files` build check will also prevent them from being included in future builds. Props johnbillion, peterwilsoncc. Fixes #65325.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Summary
$_old_filesarray inupdate-core.phpso they are removed during core upgrades.verify:old-filesGrunt task will also fail builds if these files are present in thebuild/directory, preventing recurrence.Context
Real-time collaboration was removed from core in #65205 (62334, 62337, 62338 on the 7.0 branch). However, the files still shipped in
wordpress-7.0.zipand theWordPress/WordPress7.0 tag. The impact is mostly benign since the files are not loaded, but they should be cleaned up on upgrade and excluded from future builds.Test plan
php -l src/wp-admin/includes/update-core.phppassesbuild/wp-includes/collaboration/does not exist locallynpx grunt verify:old-filesas part of a full build in CIwp-includes/collaboration.phpwp-includes/collaboration/class-wp-http-polling-sync-server.phpwp-includes/collaboration/class-wp-sync-post-meta-storage.phpwp-includes/collaboration/interface-wp-sync-storage.phpBackport
This change should be backported to the 7.0 branch for the 7.0.1 milestone.
Trac ticket: https://core.trac.wordpress.org/ticket/65325