Adding websocket heartbeat by madAndroid · Pull Request #333 · actions/runner-container-hooks

madAndroid · 2026-03-31T08:39:53Z

Addresses the issue in Kubernetes mode terminating early or not terminating at all. #228
Inspired by @vvanouytsel-trendminer change here

Copilot

Pull request overview

Adds a WebSocket heartbeat around Kubernetes exec sessions to reduce premature termination / stalled connections in “kubernetes mode” runners (Issue #228).

Changes:

Introduces ping/pong heartbeat timers (configurable via env vars) for the exec WebSocket.
Adds WebSocket lifecycle cleanup (close-with-timeout) on success/failure paths.
Expands debug logging around execPodStep and heartbeat behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

nikola-jokic · 2026-05-14T14:50:25Z

Hey @madAndroid, can you please address reviews from Copilot? Comments do make sense to me ☺️

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

madAndroid · 2026-05-17T15:53:38Z

Thanks for taking a look at this @nikola-jokic :)

I've had Claude in VSCode review and provide suggested fixes to the review comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

packages/k8s/package-lock.json: Language not supported

madAndroid · 2026-05-19T15:10:51Z

Most recent review comments addressed, and linting fixed

oradwell · 2026-05-22T15:23:25Z

@madAndroid thanks for working on this. looking forward to getting this fix in our hands. I'd be happy to help with any testing

@nikola-jokic is it possible to get this backported to 0.7.x, please?

nikola-jokic

This is awesome, thank you!

madAndroid · 2026-05-27T15:22:49Z

This is awesome, thank you!

Thank you for accepting the pull request! We can now move away from our fork 👌🎉

oradwell · 2026-05-28T08:39:53Z

@nikola-jokic any chance we can get this backported to 0.7.x and released as 0.7.1?

* Adding websocket heartbeat * Change error to debug * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Commit Claude created fixes * Remove peer entries causing pipeline failures * Fix linting * Push review fixes * Fix linting failures --------- Co-authored-by: Andrew Stangl <andrew.stangl@tesco.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

… fix Pulls k8s and k8s-novolume runner-container-hooks from oradwell/runner-container-hooks (v0.7.1-alpha / v0.8.2-alpha) instead of upstream. These community alpha releases backport PR actions/runner-container-hooks#333, which adds a websocket heartbeat to the kubernetes exec call. Without it, workflow steps that produce no output for ~5 minutes (e.g. long sleeps, silent test runs) cause the websocket to close and the step to be reported as exit 0, masking real failures. See actions/runner-container-hooks#228. Upstream has not yet cut a release containing the fix. Revert to the upstream repo once a tagged release ships. Also adds an optional tagSuffix workflow_dispatch input to docker-publish.yml so custom builds can be published as e.g. 2.333.1-hooksfix. will be ignored, and an empty message aborts the commit. # # Date: Thu Jun 4 14:18:40 2026 +0800 # # On branch fix/runner-container-hooks-websocket-heartbeat # Your branch is up to date with 'origin/fix/runner-container-hooks-websocket-heartbeat'. # # Changes to be committed: # modified: .github/workflows/docker-publish.yml # modified: images/Dockerfile #

… fix Pulls k8s and k8s-novolume runner-container-hooks from oradwell/runner-container-hooks (v0.7.1-alpha / v0.8.2-alpha) instead of upstream. These community alpha releases backport PR actions/runner-container-hooks#333, which adds a websocket heartbeat to the kubernetes exec call. Without it, workflow steps that produce no output for ~5 minutes (e.g. long sleeps, silent test runs) cause the websocket to close and the step to be reported as exit 0, masking real failures. See actions/runner-container-hooks#228. Upstream has not yet cut a release containing the fix. Revert to the upstream repo once a tagged release ships. Also adds an optional tagSuffix workflow_dispatch input to docker-publish.yml so custom builds can be published as e.g. 2.333.1-hooksfix.

Adding websocket heartbeat

d6c977d

madAndroid requested review from a team and nikola-jokic as code owners March 31, 2026 08:39

Change error to debug

3dbee4c

Copilot AI review requested due to automatic review settings April 22, 2026 13:55

Copilot started reviewing on behalf of madAndroid April 22, 2026 13:56 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Potential fix for pull request finding

a7b2576

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

madAndroid added 2 commits May 17, 2026 17:54

Commit Claude created fixes

0256147

Remove peer entries causing pipeline failures

d7e2cb9

nikola-jokic requested a review from Copilot May 18, 2026 23:22

Copilot started reviewing on behalf of nikola-jokic May 18, 2026 23:23 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread packages/k8s/src/k8s/heartbeat.ts Outdated

madAndroid added 2 commits May 19, 2026 17:04

Fix linting

b7ec278

Push review fixes

cf769b4

oradwell mentioned this pull request May 22, 2026

Exec timeout after 5 minutes kubernetes-client/javascript#2870

Open

Fix linting failures

b3b4ea5

nikola-jokic approved these changes May 27, 2026

View reviewed changes

nikola-jokic merged commit ee5c48b into actions:main May 27, 2026
5 checks passed

oradwell mentioned this pull request May 28, 2026

Kubernetes mode terminating early or not terminating at all. #228

Open

4 tasks

LMAN-se mentioned this pull request May 29, 2026

ARC Runner Job step getting stuck until timeout or prematurely starting next Job step while the previous step process is still in progress actions/actions-runner-controller#4020

Open

This was referenced Jun 4, 2026

Sorry! This PR was intended to created within my own fork only actions/runner#4477

Closed

Use community fork of runner-container-hooks with websocket heartbeat fix deftdevs/actions-runner#1

Merged

Conversation

madAndroid commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nikola-jokic commented May 14, 2026

Uh oh!

madAndroid commented May 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

madAndroid commented May 19, 2026

Uh oh!

oradwell commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nikola-jokic left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

madAndroid commented May 27, 2026

Uh oh!

oradwell commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

madAndroid commented Mar 31, 2026 •

edited

Loading

oradwell commented May 22, 2026 •

edited

Loading

nikola-jokic left a comment •

edited

Loading

oradwell commented May 28, 2026 •

edited

Loading