fix(cache): ensure trailing slash when joining base URL with API path#2411
Open
jjoseph456 wants to merge 1 commit into
Open
fix(cache): ensure trailing slash when joining base URL with API path#2411jjoseph456 wants to merge 1 commit into
jjoseph456 wants to merge 1 commit into
Conversation
When ACTIONS_CACHE_URL does not end with a trailing slash, the constructed URL becomes invalid (e.g. 'https://example.com_apis/artifactcache/...' instead of 'https://example.com/_apis/artifactcache/...'). This normalizes the base URL to always include a trailing slash before appending the API path segment. Fixes actions#2375 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
ACTIONS_CACHE_URL(orACTIONS_RESULTS_URL) does not end with a trailing slash,getCacheApiUrl()constructs an invalid URL:instead of:
This affects self-hosted runners and Forgejo instances where the base URL is configured without a trailing slash.
Fix
Normalize the base URL to always include a trailing slash before appending the API path segment.
Related
Fixes #2375