Skip to content

Update .npmignore#204

Open
pkuczynski wants to merge 1 commit into
alexei:masterfrom
pkuczynski:patch-1
Open

Update .npmignore#204
pkuczynski wants to merge 1 commit into
alexei:masterfrom
pkuczynski:patch-1

Conversation

@pkuczynski

Copy link
Copy Markdown

No description provided.

@lveneris

Copy link
Copy Markdown

See #205
This removes the need for an .npmignore altogether, as it is inclusive, rather than exclusive.

@pkuczynski

Copy link
Copy Markdown
Author

Yeah, it all depends on what one prefers: whitelisting or blacklisting :) There are pros and cons for both.

@lveneris

Copy link
Copy Markdown

@pkuczynski Ultimately, for bundling, whitelisting is the way to go. If you had to package someone's order for delivery in a warehouse, would you be given a list of things they haven't ordered or a list of things they have? I appreciate the sentiment, though :)

@alexei

alexei commented Mar 4, 2021

Copy link
Copy Markdown
Owner

What problem does this address?

@lveneris

lveneris commented Mar 4, 2021

Copy link
Copy Markdown

@alexei It is unnecessary now, due to my PR. However, if you wish to investigate this too, that's fine.

@pkuczynski

Copy link
Copy Markdown
Author

@alexei would you be keen moving forward or should I just close this PR?

@lveneris

lveneris commented Mar 20, 2026

Copy link
Copy Markdown

I believe it is safe to assume the project has been abandoned, since the last commit was 3 years ago.

It is deeply unfortunate that the JS ecosystem is as rigid as it is. Ancient unmaintained and wholly unnecessary packages are still getting 39 million weekly downloads. The package itself should be given a depreciation warning.

@pkuczynski

Copy link
Copy Markdown
Author

Yeah, probably, but wanted to be kind before I delete my fork...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants