Handle missing Connection header in Bedrock signing#1706
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bedrock signing fails before the HTTP request in some cases with:
KeyError: 'connection'The code in
src/anthropic/lib/bedrock/_auth.pyremoves the header withdel headers["connection"]. IfConnectionis absent (which can happen in normal httpx default header sets),httpx.Headers.__delitem__raises before any request is sent.Fix
Connectionif present:new_headers = {k: v for k, v in dict(headers).items() if k.lower() != "connection"}new_headersintoAWSRequest.This mirrors the existing guard pattern used by the AWS auth path in this repo and preserves the intent of excluding
Connectionfrom signed headers without crashing on missing keys.Scope & Behavior
Connectionheader exists.Connectionis absent.File Changed
src/anthropic/lib/bedrock/_auth.pyTesting
Not run (per request).