Skip to content

CAMEL-23450: Remove unmaintained junit-toolbox from camel-grpc and camel-thrift tests#23648

Merged
davsclaus merged 1 commit into
apache:mainfrom
rkdfx:CAMEL-23450-remove-junit-toolbox
May 30, 2026
Merged

CAMEL-23450: Remove unmaintained junit-toolbox from camel-grpc and camel-thrift tests#23648
davsclaus merged 1 commit into
apache:mainfrom
rkdfx:CAMEL-23450-remove-junit-toolbox

Conversation

@rkdfx
Copy link
Copy Markdown
Contributor

@rkdfx rkdfx commented May 29, 2026

Description

com.googlecode.junit-toolbox has had no release since 2017 and was used only by the concurrent tests in camel-grpc and camel-thrift. Replaced MultithreadingTester/ RunnableAssert with a small ExecutorService-based helper matching the existing idiom with same behaviour . Also removed the dependency from both poms and the version property in parent/pom.xml.

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

…mel-thrift tests

Signed-off-by: Ravi <13908473+rkdfx@users.noreply.github.com>
@rkdfx rkdfx marked this pull request as ready for review May 29, 2026 17:43
@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions
Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • components/camel-grpc
  • components/camel-thrift
  • parent

POM dependency changes: targeted tests included

Changed properties: junit-toolbox-version

Modules affected by dependency changes (2)
  • :camel-grpc
  • :camel-thrift
All tested modules (9 modules)
  • Camel :: JBang :: MCP
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: TUI
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: Launcher :: Container
  • Camel :: Thrift
  • Camel :: YAML DSL :: Validator
  • Camel :: YAML DSL :: Validator Maven Plugin
  • Camel :: gRPC

⚙️ View full build and test results

@davsclaus davsclaus merged commit d8db8d9 into apache:main May 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants