Skip to content

CLVM enhancements and fixes #12617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pearl1594 wants to merge 73 commits into
base: main
Choose a base branch
from

Merge branch 'main' of https://github.com/apache/cloudstack into clvm…

4730e59
Select commit
Loading
Failed to load commit list.
Draft

CLVM enhancements and fixes #12617

Merge branch 'main' of https://github.com/apache/cloudstack into clvm…
4730e59
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 22, 2026 in 5m 15s

Quality Gate failed

Failed conditions
1 Security Hotspot
33.4% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check failure on line 231 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "--yes" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1g2&open=AZ4Ig9SkLLXNfHHEi1g2&pullRequest=12617

Check failure on line 973 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9bNLLXNfHHEi1id&open=AZ4Ig9bNLLXNfHHEi1id&pullRequest=12617

Check warning on line 371 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter "host". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1g-&open=AZ4Ig9SkLLXNfHHEi1g-&pullRequest=12617

Check warning on line 4519 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 103 to 64, Complexity from 30 to 14, Nesting Level from 4 to 2, Number of Variables from 25 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9hlLLXNfHHEi1jG&open=AZ4Ig9hlLLXNfHHEi1jG&pullRequest=12617

Check warning on line 982 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1hN&open=AZ4Ig9SkLLXNfHHEi1hN&pullRequest=12617

Check failure on line 47 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostMigrationCommandWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"logger" is the name of a field in "CommandWrapper". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9OOLLXNfHHEi1gm&open=AZ4Ig9OOLLXNfHHEi1gm&pullRequest=12617

Check warning on line 2042 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9UJLLXNfHHEi1hR&open=AZ4Ig9UJLLXNfHHEi1hR&pullRequest=12617

Check failure on line 314 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9a_LLXNfHHEi1iC&open=AZ4Ig9a_LLXNfHHEi1iC&pullRequest=12617

Check warning on line 267 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter "host". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1g7&open=AZ4Ig9SkLLXNfHHEi1g7&pullRequest=12617

Check warning on line 2470 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 8 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9UJLLXNfHHEi1hW&open=AZ4Ig9UJLLXNfHHEi1hW&pullRequest=12617

Check warning on line 7549 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "clustered" local variable. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9YwLLXNfHHEi1h1&open=AZ4Ig9YwLLXNfHHEi1h1&pullRequest=12617

Check warning on line 410 in engine/storage/volume/src/test/java/org/apache/cloudstack/storage/volume/VolumeServiceImplClvmTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9AzLLXNfHHEi1gF&open=AZ4Ig9AzLLXNfHHEi1gF&pullRequest=12617

Check warning on line 83 in engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig83DLLXNfHHEi1fy&open=AZ4Ig83DLLXNfHHEi1fy&pullRequest=12617

Check warning on line 1623 in server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 92 to 64, Complexity from 23 to 14, Nesting Level from 4 to 2, Number of Variables from 23 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9dmLLXNfHHEi1io&open=AZ4Ig9dmLLXNfHHEi1io&pullRequest=12617

Check warning on line 53 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_agentMgr" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9f_LLXNfHHEi1iu&open=AZ4Ig9f_LLXNfHHEi1iu&pullRequest=12617

Check failure on line 490 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9bNLLXNfHHEi1iO&open=AZ4Ig9bNLLXNfHHEi1iO&pullRequest=12617

Check warning on line 5025 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 170 to 64, Complexity from 47 to 14, Nesting Level from 4 to 2, Number of Variables from 31 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9hlLLXNfHHEi1jD&open=AZ4Ig9hlLLXNfHHEi1jD&pullRequest=12617

Check failure on line 262 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Null is returned but a "Boolean" is expected. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9f_LLXNfHHEi1i4&open=AZ4Ig9f_LLXNfHHEi1i4&pullRequest=12617

Check failure on line 238 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "qemu-img" 5 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1g4&open=AZ4Ig9SkLLXNfHHEi1g4&pullRequest=12617

Check warning on line 884 in engine/orchestration/src/test/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestratorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9K5LLXNfHHEi1gb&open=AZ4Ig9K5LLXNfHHEi1gb&pullRequest=12617

Check warning on line 2582 in server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9n4LLXNfHHEi1jT&open=AZ4Ig9n4LLXNfHHEi1jT&pullRequest=12617

Check warning on line 211 in engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig88pLLXNfHHEi1f9&open=AZ4Ig88pLLXNfHHEi1f9&pullRequest=12617

Check failure on line 786 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9bNLLXNfHHEi1iX&open=AZ4Ig9bNLLXNfHHEi1iX&pullRequest=12617

Check warning on line 129 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPrepareForMigrationCommandWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9OjLLXNfHHEi1gn&open=AZ4Ig9OjLLXNfHHEi1gn&pullRequest=12617

Check warning on line 7199 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "details" which hides the field declared at line 260. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9YwLLXNfHHEi1hy&open=AZ4Ig9YwLLXNfHHEi1hy&pullRequest=12617
View more details on SonarQubeCloud