[WIP] Ensure VM IP is removed from VR DHCP records in dnsmasq.leases after expunge VM#13194
[WIP] Ensure VM IP is removed from VR DHCP records in dnsmasq.leases after expunge VM#13194sureshanaparti wants to merge 1 commit into
Conversation
…expunge VM This also reverts the PR apache#10183 changes (for apache#10182), in turn resulting in apache#11877.
boring-cyborg
Bot
added
component:networking
component:virtual-router
Python
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13194 +/- ##
============================================
- Coverage 16.27% 16.26% -0.01%
+ Complexity 13440 13432 -8
============================================
Files 5665 5665
Lines 500555 500555
Branches 60789 60789
============================================
- Hits 81445 81397 -48
- Misses 410004 410052 +48
Partials 9106 9106
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17911 |
| # reload dnsmasq | ||
| try: | ||
| with open("/var/run/dnsmasq.pid") as pidf: | ||
| os.kill(int(pidf.read().strip()), signal.SIGHUP) |
There was a problem hiding this comment.
can use CsHelper.service("dnsmasq", "reload") ?
There was a problem hiding this comment.
ok, will check
| except Exception: | ||
| pass | ||
|
|
||
| os.system("ip neigh flush all") |
There was a problem hiding this comment.
what's the purpose of this ?
There was a problem hiding this comment.
@weizhouapache is it good to have this, to cleanup cache entries? will remove it if not necessary.
3 participants
Description
This PR ensures VM IP is removed from VR DHCP records in dnsmasq.leases after expunge VM.
This also reverts the PR #10183 changes (for #10182), in turn resulting in #11877.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?