fix label key for gpudisplay

[sudo87]

Description

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[vishesh92]

@blueorangutan ui

[blueorangutan]

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[vishesh92]

clgtm

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.11%. Comparing base (c0ce5b4) to head (f4cdd27).

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #13272   +/-   ##
=========================================
  Coverage     18.10%   18.11%           
- Complexity    16749    16758    +9     
=========================================
  Files          6037     6037           
  Lines        542796   542796           
  Branches      66456    66456           
=========================================
+ Hits          98268    98320   +52     
+ Misses       433492   433430   -62     
- Partials      11036    11046   +10     

Flag	Coverage Δ
uitests	3.51% <ø> (ø)
unittests	19.27% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

I fail to see how this is an improvement. I would argue other lebals need an extra . after gpu...

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13272 (QA-JID-943)

[sudo87]

I fail to see how this is an improvement. I would argue other lebals need an extra . after gpu...

label.gpudisplay is currently used in the offering details and is defined here:

cloudstack/ui/src/config/section/offering.js

Line 44 in c0ce5b4

var fields = ['name', 'id', 'displaytext', 'offerha', 'provisioningtype', 'storagetype', 'iscustomized', 'iscustomizediops', 'limitcpuuse', 'cpunumber', 'cpuspeed', 'memory', 'hosttags', 'tags', 'storageaccessgroups', 'storagetags', 'domain', 'zone', 'created', 'dynamicscalingenabled', 'diskofferingstrictness', 'encryptroot', 'purgeresources', 'leaseduration', 'gpucardid', 'gpucardname', 'vgpuprofileid', 'vgpuprofilename', 'gpucount', 'gpudisplay', 'leaseexpiryaction', 'externaldetails']

We need to define 'label.gpudisplay' to render the label value. I avoided duplicating the key 'label.gpu.display' and renamed it to label.gpudisplay to keep it single-sourced.