[CXF-9218]Respect configured ProxySelector instead of hard-wiring sys…#3154
Merged
Conversation
…tem proxy properties
reta
reviewed
May 29, 2026
reta
approved these changes
May 29, 2026
Contributor
Author
|
Thanks @reta ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tem proxy properties
Summary
ProxyFactorywas readinghttp.proxyHost,http.proxyPort, andhttp.nonProxyHostsdirectly from system properties at construction time, bypassing Java's
ProxySelectormechanism entirely. This prevented applications from using custom
ProxySelectorimplementations — for example, wrapping
sun.net.spi.DefaultProxySelectorto selectivelybypass the proxy for specific hosts.
The fix removes the system-property reading from
ProxyFactoryand delegates toProxySelector.getDefault()instead. When no customProxySelectoris installed thebehaviour is identical to before (
DefaultProxySelectorreads the same system propertiesinternally). When a custom
ProxySelectoris installed it is now consulted as expected.The explicit
HTTPClientPolicy.setProxyServer(...)path is unaffected.Behaviour notes
DefaultProxySelectorreadshttp.proxyHost/http.proxyPort/http.nonProxyHostsexactly as before.HttpClientHTTPConduitandURLConnectionHTTPConduitbenefit from this fix.