Tolerate sub-millisecond differences in TDML dateTime comparison#1682
Open
gdesrosiers1805 wants to merge 1 commit into
Open
Tolerate sub-millisecond differences in TDML dateTime comparison#1682gdesrosiers1805 wants to merge 1 commit into
gdesrosiers1805 wants to merge 1 commit into
Conversation
stevedlawrence
approved these changes
Jun 11, 2026
gdesrosiers1805
force-pushed
the
bugfix/daffodil-3086
branch
from
5391813 to
85629da
Compare
olabusayoT
approved these changes
Jun 11, 2026
olabusayoT
left a comment
olabusayoT
left a comment
Contributor
There was a problem hiding this comment.
+1 minor comment about embedded schema name to prevent confusion down the line
ICU calendars are millisecond-precision, so fractional microseconds in xs:dateTime values are not preserved on parse. Truncate fractional seconds to milliseconds from the XMLGregorianCalendars before comparison, so sub-millisecond differences are ignored rather than flagged as mismatches. DAFFODIL-3086
gdesrosiers1805
force-pushed
the
bugfix/daffodil-3086
branch
from
85629da to
61ba022
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICU calendars are millisecond-precision, so fractional microseconds in
xs:dateTime values are not preserved on parse. Truncate fractional seconds
to milliseconds from the XMLGregorianCalendars before comparison, so
sub-millisecond differences are ignored rather than flagged as mismatches.
DAFFODIL-3086