Improve accuracy of supports_string_literal_concatenation_with_newline#2348
Merged
Conversation
iffyio
reviewed
May 21, 2026
| // Tokenizer includes the newline in the single line comment | ||
| // so we need to check for it specifically here, otherwise the newline will | ||
| // not be consumed as a separate token. | ||
| Token::Whitespace(Whitespace::SingleLineComment { comment, .. }) => { |
Contributor
There was a problem hiding this comment.
I'm wondering would it make sense to strip out the newline from the tokenizer instead? thinking that feels more like expected behavior for folks that rely on the content of a single line comment
Contributor
Author
There was a problem hiding this comment.
It would, I just thought it would be a disruptive change. However, I gave it a try and I think it makes sense. Take a look.
yoavcloud
force-pushed
the
cocnat_newline_comment
branch
from
6f3bbaa to
6416bc7
Compare
yoavcloud
force-pushed
the
cocnat_newline_comment
branch
from
9dd202c to
9e80552
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.