Skip to content

Fixed the Chinese logger of schema#17721

Merged
Caideyipi merged 3 commits into
masterfrom
schema-fix
May 28, 2026
Merged

Fixed the Chinese logger of schema#17721
Caideyipi merged 3 commits into
masterfrom
schema-fix

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.42%. Comparing base (34cc346) to head (28f3b41).

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #17721   +/-   ##
=========================================
  Coverage     40.41%   40.42%           
  Complexity     2574     2574           
=========================================
  Files          5179     5179           
  Lines        349767   349767           
  Branches      44714    44714           
=========================================
+ Hits         141373   141399   +26     
+ Misses       208394   208368   -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

luoluoyuyu

This comment was marked as outdated.

Copy link
Copy Markdown
Member

@luoluoyuyu luoluoyuyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Fixes Chinese schema log templates so placeholder order matches call sites, and adds DataNodeSchemaMessagesZhFormatTest to prevent regressions.

Looks good to merge.

@Caideyipi Caideyipi merged commit 152ee1d into master May 28, 2026
44 checks passed
@Caideyipi Caideyipi deleted the schema-fix branch May 28, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants