Fix fast last query handling for empty last-cache entries#17742
Open
Caideyipi wants to merge 1 commit into
Open
Fix fast last query handling for empty last-cache entries#17742Caideyipi wants to merge 1 commit into
Caideyipi wants to merge 1 commit into
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17742 +/- ##
============================================
+ Coverage 40.47% 40.59% +0.12%
Complexity 2574 2574
============================================
Files 5179 5179
Lines 349942 349943 +1
Branches 44737 44738 +1
============================================
+ Hits 141631 142072 +441
+ Misses 208311 207871 -440 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Motivation
Fast last query cache may contain
TableDeviceLastCache.PLACEHOLDER_EMPTY_COLUMNfor measurements that have no lastvalue. Some cache-hit response paths only checked whether the cached value was
null, so the placeholder entry couldbe handled as a normal cached value.
Modification
This PR treats
PLACEHOLDER_EMPTY_COLUMNas an empty last-cache entry in fast last query response building.Changes include:
executeFastLastDataQueryForOneDeviceV2.Key changed/added classes in this PR
ClientRPCServiceImplRestApiServiceImplThis PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR