KNOX-3360: create-k8s-alias command to save aliases from k8s secrets#1279
Merged
Conversation
Test Results28 tests 28 ✅ 3s ⏱️ Results for commit 5d2be2e. ♻️ This comment has been updated with latest results. |
moresandeep
requested changes
Jun 25, 2026
moresandeep
left a comment
Contributor
There was a problem hiding this comment.
Few things:
- I added my observation regarding
secret.getData()on the review the other two below are minor nits. - in case of batch/bulk mode if
secret-asucceeds andsecret-bfails looks like secret-a’s alias will be persisted with no rollback, is this expected? - I think we'll need a DOC jira for this :)
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3360 - New KnoxCLI command to save alias from k8s secret
What changes were proposed in this pull request?
create-k8s-aliasthat adds k8s secrets as aliases--nsor--namespaceflag to specify where the secrets live, it defaults toknox__gatewayHow was this patch tested?
Unit tests, tested on local kind cluster
Secrets
./knoxcli.sh create-k8s-alias stringdatasecret datasecretIntegration Tests
N/A
UI changes
N/A