ostest: Fix ostest for CONFIG_ENABLE_PARTIAL_SIGNALS and CONFIG_DISABLE_ALL_SIGNALS#3538
Open
jlaitine wants to merge 1 commit into
Open
ostest: Fix ostest for CONFIG_ENABLE_PARTIAL_SIGNALS and CONFIG_DISABLE_ALL_SIGNALS#3538jlaitine wants to merge 1 commit into
jlaitine wants to merge 1 commit into
Conversation
POSIX timers test doesn't really need signal actions, so we can change it to synchronously wait for the signal in sigwaitinfo, instead of registering a signal handler. Also exclude the test from compilation with CONFIG_DISABLE_ALL_SIGNALS; the test does require at least partial signal support. Signed-off-by: Jukka Laitinen <jukka.laitinen@tii.ae>
xiaoxiang781216
previously approved these changes
Jun 13, 2026
Contributor
Author
|
I'll enable the robust mutex test back with CONFIG_DISABLE_ALL_SIGNALS, as soon as I get the pthread_kill with signo == 0 fixed right acc. to the comment in nuttx. |
jlaitine
force-pushed
the
ostest_partial_signals
branch
from
456f631 to
a959e60
Compare
xiaoxiang781216
approved these changes
Jun 13, 2026
Contributor
|
+1 :-)
…--
CeDeROM, SQ7MHZ, http://www.tomek.cedro.info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Posix timers test doesn't really need signal actions, so we can change it to synchronously wait for the signal in sigwaitinfo, instead of registering a signal handler.
This has the following advantages:
The robust mutexes can't work withtout pthread_kill, which requires signals, so remove those if CONFIG_DISABLE_ALL_SIGNALS is defined
Impact
This corrects the functionality of ostest for other than CONFIG_ENABLE_ALL_SIGNALS.
Testing
Tested on qemu-armv8a:nsh , together with change in NuttX PR apache/nuttx#19116