SOLR-18270 CertAuthPlugin : update the lookup attribute (without parametrization)#4474
Open
heitzjm wants to merge 3 commits into
Open
SOLR-18270 CertAuthPlugin : update the lookup attribute (without parametrization)#4474heitzjm wants to merge 3 commits into
heitzjm wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18270
Description
This PR only update the request attribute used by CertAuthPlugin to match the one filled by Jetty 12 - for SOLR 10. SOLR 9 works fine in the Official Docker Image, as it uses a lower major Jetty version, so it should only be merged in Solr 10 branches (other PR with parametrization that should be suitable for both SOLR 9 and 10 coming).
Solution
This PR only update the request attribute used by CertAuthPlugin to match the one filled by Jetty 12 - for SOLR 10.
Tests
I checked locally by compiling SOLR from source, as well as building Docker Image from source and tested it in a K8S environment.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.5582 tests completed, 1 failed, 184 skipped
ERROR: The following test(s) have failed:
=> however, in my opinion, this test does not seem to be relevant for this PR
unreleased/SOLR-18270-easy-fix-without-parametrization.yml