Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalhostOnlydidn't detect a few of the IPv6 variants.Furthermore, it might trigger a DNS lookup, which could impact performance.
Therefore, it now relies on
HttpServletRequest.getRemoteAddr(via Request).I've decided to extend the
Requestinterfrace withgetRemoteAddrinstead of trying to provideLocalhostOnlywith theHttpServletRequestsomehow.My reasoning is that
Requestis already a more high-level/convenient wrapper forHttpServletRequest, delegating multiple methods already to the underlyingHttpServletRequest.Adding another one makes sense, as anything relying on
LocalhostOnly would need to provide the full/correct environment. This was an issue during initial testing with usingRequestGlobalsinLocalhostOnly`, as it became an invisible dependency.By extending
Requestand the relatedTestableRequestandDelegatingRequest, theRequest-based code will behave correctly, regardless of how it's used.