TOMEE-4589 - Trim whitespace in numeric/enum descriptor values#2794
Open
rzo1 wants to merge 1 commit into
Open
TOMEE-4589 - Trim whitespace in numeric/enum descriptor values#2794rzo1 wants to merge 1 commit into
rzo1 wants to merge 1 commit into
Conversation
session-timeout (and the other xsd:integer / numeric / temporal / enum
descriptor values) use a whitespace="collapse" facet, so a value such as
<session-timeout>
30
</session-timeout>
is valid and must parse. The SXC-generated accessors fed the raw element
text straight into Integer.valueOf()/etc. for wrapper, temporal, decimal
and enum types, which failed with NumberFormatException.
Bump SXC to 0.10 (which collapses whitespace in the generator) and
regenerate the affected accessors, applying only the resulting .trim()
additions so the change stays limited to the fix. Adds a regression test.
jungm
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session-timeout (and the other xsd:integer / numeric / temporal / enum descriptor values) use a whitespace="collapse" facet, so a value such as
is valid and must parse. The SXC-generated accessors fed the raw element text straight into Integer.valueOf()/etc. for wrapper, temporal, decimal and enum types, which failed with NumberFormatException.
Bump SXC to 0.10 (which collapses whitespace in the generator) and regenerate the affected accessors, applying only the resulting .trim() additions so the change stays limited to the fix. Adds a regression test.