eventbridge-sfn-terraform: Update AWS Provider to v6#3069
Conversation
| } | ||
|
|
||
| # Create an IAM policy for Eventbridge to be able to start a Step Function execution | ||
| # Create an IAM policy for Eventbridge to be able to start a Step Functions execution |
There was a problem hiding this comment.
note: Fix to correct service name😀
https://docs.aws.amazon.com/step-functions/latest/dg/welcome.html
There was a problem hiding this comment.
Naming: Request you to refer the official Lambda durable functions docs. Same applies in hitl-lambda-durable-function-cdk/README.md and fix pre-existing nits for AWS Service names, including this one.
There was a problem hiding this comment.
@parikhudit
I believe hitl-lambda-durable-function-cdk is still an open pull request and has not been merged yet, so it's outside the scope of this PR.
Once it gets merged, I'd be happy to send a separate pull request to fix any AWS service name issues there😀
Thanks!
|
@kakakakakku Thanks for the v6 bump and the service name fix. |
| aws = { | ||
| source = "hashicorp/aws" | ||
| version = "~> 3.27" | ||
| version = "~> 6.0" |
There was a problem hiding this comment.
Optional: jumping ~> 3.27 → ~> 6.0 skips v4 and v5. The Terraform v6 upgrade guide recommends stepping through the latest 5.x first. None of the resources used here seem to have v6 breaking changes, so for fresh deployments this works. However, please confirm in the PR description that you've run terraform init && terraform apply against ~> 6.0 end-to-end.
Thanks
There was a problem hiding this comment.
@parikhudit
Thanks for the review!
I believe the patterns in this repository are mainly intended for builders to try out and then tear down shortly after. So I don't think we need to be as strict about stepping through major versions as we would in a production environment.
For this PR, I've confirmed the pattern works end-to-end with AWS Provider v6. I had already attached the verification logs in the PR description from the beginning, and I've now also added the terraform --version and terraform apply logs as well.
How does that look?
Thanks👍
Issue #, if available:
N/A
Description of changes:
Hi😀 Thanks for the useful patterns!
To keep this pattern maintainable, I updated the AWS Provider to v6.
Check
terraform applycompleted successfully and works good.$ aws events put-events --entries file://event-A.json --region us-east-1 { "FailedEntryCount": 0, "Entries": [ { "EventId": "c50fee9c-1316-0d0d-b8e1-e53d12c1289f" } ] } $ aws events put-events --entries file://event-B.json --region us-east-1 { "FailedEntryCount": 0, "Entries": [ { "EventId": "5369ae64-7800-6347-1b6a-7a36d89b6c2a" } ] } $ aws events put-events --entries file://event-Fail.json --region us-east-1 { "FailedEntryCount": 0, "Entries": [ { "EventId": "9710a0b6-a0bc-1471-28d6-1324da7c5bf5" } ] }Thank you😀
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.