Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1685 +/- ##
=======================================
Coverage 89.59% 89.59%
=======================================
Files 77 77
Lines 11716 11716
Branches 1624 1638 +14
=======================================
Hits 10497 10497
Misses 1190 1190
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes the TypeScript baseline for all packages:
es2022,module: node18,esModuleInterop, andnoEmitOnError, replacing a set of per-packagetsconfigoverrides with one shared config.The rest of the change adapts the code to
esModuleInterop. Modules whose top-level export is used directly (chalk,nock,mock-fs,assert) become default imports, since under interop a namespace import drops the call signature and non-enumerable members — leaving them as-is would compile but fail at runtime (e.g.chalk.green is not a function).In tests, modules mocked via
jest.spyOn/sinon.stub/withMocked(fs,os,child_process,https) also become default imports so they stay mutable under interop, and one dynamicimport()became static to satisfynode16resolution.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license