feat: add InputSelect composition#647
Open
isaquebock wants to merge 5 commits into
Open
Conversation
Introduce `@aziontech/webkit/inputs/input-select` and its sub-components (`input-select-trigger`, `input-select-content`, `input-select-group`, `input-select-option`), composed via a shared injection key for context sharing without prop drilling. The composition pattern follows the shadcn-vue convention: the consumer controls the structure (`<InputSelect><InputSelectTrigger /><InputSelectContent> <InputSelectGroup><InputSelectOption /></InputSelectGroup></InputSelectContent></InputSelect>`), while the parent `InputSelect` owns selection state and exposes `modelValue` + `update:modelValue` for v-model binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce
@aziontech/webkit/inputs/input-selectand its sub-components, composed via a shared injection key:input-select— root, owns selection state + emitsupdate:modelValue.input-select-trigger— the clickable trigger that opens the listbox.input-select-content— the floating listbox surface.input-select-group— optional grouping with header.input-select-option— individual option, picks selected value via the shared context.The composition follows the shadcn-vue convention: the consumer controls the structure, the root owns state.
Independent from the other inputs PRs in the series (no shared imports with Label / HelperText / InputText).
Test plan
pnpm --filter @aziontech/webkit lint— clean.Webkit/Inputs/InputSelect→ open the trigger, pick an option, value reflects in the controls panel.Tabto trigger →Enter/Spaceto open → arrows navigate →Enterselects →Esccloses.Known type-check noise
pnpm --filter @aziontech/webkit type-checkreports the following errors in this PR's scope — they reflect known Vue 3Booleanish | undefinednarrowing limitations arounddata-*attrs and an emit overload conflict. Tracking separately; do not block this PR:input-select-content.vue(121,10)—Booleanish | undefinedondata-*attrsinput-select-option.vue(62,6)— sameinput-select-trigger.vue(39, 46-48)— same +HTMLElement | nullref typinginput-select.vue(85, 106)—emit('update:modelValue', value)overload mismatch