Add POL address sync verifier and make check targets#57
Open
camembera wants to merge 1 commit into
Open
Conversation
Mechanical check that POLAddresses.sol, pol-addresses-mapping.json, and contracts.json stay aligned for published mainnet/bepolia addresses, with CONTRIBUTING and Cursor rule guidance for the four-layer workflow.
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
The general idea is eventually we can get an LLM to turn this crank automatically for merges that happen in either contracts or contracts-internal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it easy to keep POL Addresses published in POLAddresses.sol published, in docs.
Requires contracts-internal checked out alongside docs. Can override dir in Makefile.
make check-pol-addresses- provides ✅make list-pol-addresses-not-ok- provides details of what's 👎This is driven by data/pol-addresses-mapping.json. This file contains decisions about whether or not to publish a POL Address to docs.
Test plan
make check-pol-addressespasses with siblingcontracts-internalcloned (ok=26 not_ok=0)make list-pol-addresses-not-oklists rows when drift is introducedpublished: falseomissions (deprecated contracts, implementations)