Fix #278: find project config in parent directories from relative root#281
Open
blopker wants to merge 1 commit into
Open
Fix #278: find project config in parent directories from relative root#281blopker wants to merge 1 commit into
blopker wants to merge 1 commit into
Conversation
find_project_config walked up via parent(), but a relative start dir
(the CLI's default ".") dead-ends immediately since Path::new(".")
.parent() is "" and "".parent() is None, so it only ever checked the
cwd. Make the start dir absolute before walking. Use std::path::absolute
rather than canonicalize to avoid resolving symlinks, keeping absolute
inputs (e.g. an editor's workspace root) unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_project_config walked up via parent(), but a relative start dir (the CLI's default ".") dead-ends immediately since Path::new(".") .parent() is "" and "".parent() is None, so it only ever checked the cwd. Make the start dir absolute before walking. Use std::path::absolute rather than canonicalize to avoid resolving symlinks, keeping absolute inputs (e.g. an editor's workspace root) unchanged.