-
Notifications
You must be signed in to change notification settings - Fork 222
Try to fix Windows CI (GitHub Actions -- vcpkg manifest mode) #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stephengtuggy
wants to merge
14
commits into
boostorg:develop
Choose a base branch
from
stephengtuggy:fix/windows-ci
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+83
−20
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f11618c
Create vcpkg.json
stephengtuggy 8638eea
Update test-windows.yml
stephengtuggy c77ed5d
Update test-windows.yml: Fix the `--with-boost-include` directory pas…
stephengtuggy 210231a
List vcpkg directory contents, looking for config.hpp
stephengtuggy bd14940
vcpkg.json: Go back to the same commit for builtin-baseline as was us…
stephengtuggy 5d00264
Merge branch 'boostorg:develop' into fix/windows-ci
stephengtuggy b101bc8
test-windows.yml: Set VCPKG_ROOT environment variable, etc.
stephengtuggy 5f234ee
test-windows.yml: Make workflow much more like my other, working proj…
stephengtuggy 7cf1dc4
test-windows.yml: Search the entire github.workspace directory and su…
stephengtuggy bc83f51
test-windows.yml: Update `microsoft/setup-msbuild` to latest version,…
stephengtuggy 8ed3dbe
vcpkg.json: Go back to latest vcpkg release for builtin-baseline
stephengtuggy 96a1891
test-windows.yml: Try again to set the correct with-boost-include dir…
stephengtuggy 2732a51
test-windows.yml: Set VCPKG_INSTALLED_DIR env var, and use its value …
stephengtuggy 2460f88
test-windows.yml: Forgot to include `/x64-windows/include` in `--with…
stephengtuggy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json", | ||
| "name": "boost-python", | ||
| "version-string": "1.91.0", | ||
| "builtin-baseline": "f3e10653cc27d62a37a3763cd84b38bca07c6075", | ||
| "dependencies": [ | ||
| "boost-config", | ||
| "boost-core", | ||
| "boost-function", | ||
| "boost-graph", | ||
| "boost-iterator", | ||
| "boost-lexical-cast", | ||
| "boost-mpl", | ||
| "boost-preprocessor", | ||
| "boost-smart-ptr", | ||
| "boost-static-assert", | ||
| "boost-align", | ||
| "python3" | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you are referring to all actions by sha. Is that really necessary ? Why not use a version tag instead ? Wouldn't that be simpler (more readable, easier to maintain, etc.) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Referring to GitHub Actions by SHA is considered a security best practice. See https://docs.github.com/en/actions/reference/security/secure-use?learn=getting_started#using-third-party-actions .
It's not too difficult to maintain if one uses a tool like Dependabot or Renovate[bot] to keep dependencies up to date, including GitHub Actions dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for readability, I do at least include the version tag in a comment. Hopefully that helps at least a little bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I noticed. Thanks !
Please go ahead and merge this if you are satisfied with the PR. Many thanks again for all your effort on this ! I wouldn't have been able to pull this off on my own, as I haven't developed on & for Windows in a long time.
Your work will unblock a number of other changes that I was hesitant to add while the Windows build was broken, so I'm thrilled to see this being completed.
Cheers !