Skip to content

benchmark cpu: drop KDF section#9665

Merged
ThomasWaldmann merged 2 commits into
borgbackup:masterfrom
mr-raj12:benchmark-drop-kdf-section
May 24, 2026
Merged

benchmark cpu: drop KDF section#9665
ThomasWaldmann merged 2 commits into
borgbackup:masterfrom
mr-raj12:benchmark-drop-kdf-section

Conversation

@mr-raj12
Copy link
Copy Markdown
Contributor

@mr-raj12 mr-raj12 commented May 24, 2026

Drops the KDF section from do_benchmark_cpu.

KDFs are supposed to be slow, that's the whole point. Timing them gives no useful signal, and the benchmark output already said so: "KDFs (slow is GOOD, use argon2!)".

Suggested in #9664 (review).

  • Removed the KDF benchmark block (print header + for loop)
  • Removed number_kdf and the FlexiKey import, both only used by that block

No logic changes.

Checklist

  • PR is against master
  • New code has tests
  • Tests pass
  • Commit message references related issue

@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.62%. Comparing base (b0f3096) to head (fea52ef).
⚠️ Report is 22 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9665      +/-   ##
==========================================
+ Coverage   83.00%   83.62%   +0.61%     
==========================================
  Files          90       90              
  Lines       15549    15539      -10     
  Branches     2340     2337       -3     
==========================================
+ Hits        12907    12995      +88     
+ Misses       1887     1806      -81     
+ Partials      755      738      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ThomasWaldmann ThomasWaldmann merged commit 832bb44 into borgbackup:master May 24, 2026
20 checks passed
@ThomasWaldmann
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants