Fix off by one error#3406
Merged
Merged
Conversation
Contributor
Author
|
Cherry-picked from #3330 - which has a test that failed without this fix, as no boundaries where applied. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| Ind3D _ind() const { return region->bndry_points[pos].index; } | ||
| signed char _boundary_width() const { | ||
| return region->localmesh->ystart - region->bndry_points[pos].abs_offset; | ||
| return region->localmesh->ystart - region->bndry_points[pos].abs_offset + 1; |
Contributor
There was a problem hiding this comment.
warning: narrowing conversion from 'int' to signed type 'signed char' is implementation-defined [bugprone-narrowing-conversions]
{
^
Member
There was a problem hiding this comment.
The signed char as a return type seems unnecessary, but we should at least have static_cast here
Contributor
Author
There was a problem hiding this comment.
👍 Fair point, we later return anyway an int.
ZedThree
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearly we need more tests for the FCI boundary operator.