fix(theme): drop stray centered home-hero glow (1.2.1)#14
Merged
Conversation
The `.VPHome::before` flourish painted a hard-centered radial glow at the top of every VitePress home page. On the docs sites that reads as a bug: a big pink halo floating in the top-middle, disconnected from the hero — whose logo the default home layout places on the RIGHT, not centered. (The landing page never used it either; it has its own bespoke `layout: false` hero.) Remove the standalone glow. The hero logo keeps its halo via `--vp-home-hero-image-background-image`, which sits behind the image itself and tracks it wherever the layout puts it. Bump to 1.2.1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes an unintended, hard-centered glow effect applied to VitePress home layouts so docs sites no longer show a “floating” halo at the top of the page, while preserving the intended glow behind the hero logo via the existing --vp-home-hero-image-background-image token.
Changes:
- Deleted the
.VPHome::before(and dark variant) centered radial glow flourish from the shared theme CSS. - Kept the hero-logo glow behavior anchored to the image background token and retained the floating logo animation.
- Bumped
@btravstack/themeversion from1.2.0to1.2.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/theme/src/style.css | Removes the centered .VPHome::before glow while keeping the hero image’s token-based glow and animation. |
| packages/theme/package.json | Patch version bump to publish the theme fix as 1.2.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs sites show a big pink halo floating in the top-middle of the home page (visible at https://btravstack.github.io/amqp-contract/).
Cause
The
.VPHome::beforeflourish painted a hard-centered radial glow at the top of any VitePresshomelayout. But:.VPHome(it uses its own bespokelayout: false+<Landing />hero), so the flourish only ever affected the docs sites; andFix
Remove the standalone
.VPHome::beforeglow (and its.darkvariant). The hero logo keeps its halo via--vp-home-hero-image-background-image, which sits behind the image itself and tracks it wherever the layout places it. Patch bump1.2.0 → 1.2.1.Verification
Simulated the fix against the live site (inject
.VPHome::before{display:none}): the stray top-center halo disappears, the right-side hero logo keeps its own glow, and mobile has no horizontal overflow (scrollWidth == innerWidth). Inner content pages were already clean.Release
Same as 1.2.0 — merge, then publish:
Once
1.2.1is live, I'll bump the three docs sites onto it so the fix deploys (pnpm update @btravstack/themein each + redeploy).🤖 Generated with Claude Code