Add support for protobuf-py#482
Open
anuraaga wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #339
This rewrites the protovalidate rules engine to protobuf-py, adding native support for it.
google.protobufcompatibility is preserved with an optional dependency on it - we just copy into protobuf-py dynamic messages to keep to a single engine.The change is largely mechanical, from one descriptor API to a different one, but is by nature all in so it is a large diff.
This also executes our plan to take advantage of protobuf-py to finally fix #339, a user does not have to bring in their own validate proto gencode for this library to work as we just vendor it in. If a user also vendors it in, no problem since no global descriptor pool conflicts.