Skip to content

chore: keep release-please pre-1.0 (breaking changes bump minor, not major)#199

Merged
27Bslash6 merged 1 commit into
mainfrom
chore/release-please-pre-major
Jun 20, 2026
Merged

chore: keep release-please pre-1.0 (breaking changes bump minor, not major)#199
27Bslash6 merged 1 commit into
mainfrom
chore/release-please-pre-major

Conversation

@27Bslash6

@27Bslash6 27Bslash6 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Why

cachekit is still alpha (Development Status :: 3 - Alpha, version 0.x). release-please's default treats a BREAKING CHANGE as a major bump even below 1.0.0 — so the orjson optional-dependency change (#196, which carried a BREAKING CHANGE: footer for the install-contract change) made release-please open #198 "release 1.0.0". We don't want to ship 1.0.0 yet.

Fix

Set bump-minor-pre-major: true on the package. While the version is below 1.0.0, breaking changes now bump the minor (0.10.1 → 0.11.0) instead of jumping to 1.0.0. The breaking change is still surfaced in the changelog — it just doesn't escalate the major version prematurely.

Once this lands on main, release-please recomputes the pending release PR (#198) from 1.0.0 to 0.11.0.

Notes

  • This is the durable fix: every future pre-1.0 breaking change behaves correctly, not just this one.
  • Optional, not included here: bump-patch-for-minor-pre-major: true would also make plain feat: commits bump patch (not minor) while pre-1.0 — an even more conservative alpha cadence. Left out so this PR only addresses the 1.0.0 escalation; easy to add if you want features to stay patch-level too.
  • Mea culpa on the trigger: the BREAKING CHANGE: footer on the orjson commit was over-ceremony for an alpha project. The merged commit can't be cleanly reworded, but this config makes its (and any future) breaking change resolve to a sane pre-1.0 version.

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated release configuration settings to refine versioning behaviour during the release process.

…major)

cachekit is still alpha (Development Status :: 3 - Alpha, version 0.x). Without
bump-minor-pre-major, release-please escalates any BREAKING CHANGE straight to
1.0.0 — which is why the orjson optional-dependency change (#196) produced a
"release 1.0.0" PR (#198).

Set bump-minor-pre-major so that while the version is below 1.0.0, breaking
changes bump the minor (0.10.1 -> 0.11.0) instead of the major. Once this lands
on main, release-please recomputes the pending release PR to 0.11.0.
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a6e31dea-f0a4-4a66-b832-70b263a24a67

📥 Commits

Reviewing files that changed from the base of the PR and between 4512a2a and 515a4a0.

📒 Files selected for processing (1)
  • release-please-config.json

Walkthrough

release-please-config.json is updated to add bump-minor-pre-major: true under the "packages"."." configuration, sitting alongside the existing include-component-in-tag: false setting.

Changes

Release Please Configuration Update

Layer / File(s) Summary
Add bump-minor-pre-major setting
release-please-config.json
Adds bump-minor-pre-major: true to the root package configuration entry, alongside the existing include-component-in-tag: false.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarises the main change: configuring release-please to treat breaking changes as minor version bumps pre-1.0 instead of major bumps.
Description check ✅ Passed The description provides comprehensive context: the problem (unintended 1.0.0 release trigger), the solution (bump-minor-pre-major configuration), and implementation notes. It adequately covers motivation and reasoning.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/release-please-pre-major

Comment @coderabbitai help to get the list of available commands and usage tips.

@27Bslash6 27Bslash6 merged commit 83766a1 into main Jun 20, 2026
32 checks passed
@27Bslash6 27Bslash6 deleted the chore/release-please-pre-major branch June 20, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant