fix: repack re-bundled simulator .app on non-PR events#29
Open
olerass wants to merge 1 commit into
Open
Conversation
callstackincubator#15 added support for re-sign on regular commits, and callstackincubator#22 added the missing repack step for simulator builds, but scoped it to pull_request events only. On __push__ events with a remote-cache hit, however, the flow is currently: 1. The cached app.tar.gz is downloaded and extracted 2. rock sign:ios --build-jsbundle --app rebuilds a fresh JS bundle into the extracted .app 3. The repack step is skipped (PR-only condition), so ARTIFACT_PATH still points to the stale downloaded tar.gz 4. That stale archive is uploaded under the new commit-sha artifact name So push-event consumers (e.g. E2E suites running against the artifact on the main branch) test an outdated JS bundle, which is the issue we're seeing at Rainbow in our current CI setup. To fix it, this change aligns the repack condition with the preceding Re-bundle APP step, so the re-bundled .app is always repacked before upload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#15 added support for re-sign on regular commits, and #22 added the missing repack step for simulator builds, but scoped it to pull_request events only.
On push events with a remote-cache hit, however, the flow is currently:
So push-event consumers (e.g. E2E suites running against the artifact on the main branch) test an outdated JS bundle, which is the issue we're seeing at Rainbow in our current CI setup.
To fix it, this change aligns the repack condition with the preceding "Re-bundle APP" step, so the re-bundled
.appis always repacked before upload regardless of trigger. We've been running this patch from a fork in rainbow-me/rainbow and confirmed push-event runs now repack and test the fresh bundle (example run).