Update test environment to make tests pass again#42
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s test tooling and CI configuration so the PHPUnit test suite can run reliably again across supported runtimes (including legacy PHP and HHVM), aligning configuration with newer PHPUnit and workflow environments.
Changes:
- Update PHPUnit config schema references (legacy + modern) and align composer dev requirement to PHPUnit
^9.6. - Add
react/promise-timeras a dev dependency to support timer helpers used in tests. - Refresh CI workflow environment (Ubuntu version, checkout action) and adjust HHVM execution to run via Docker.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
phpunit.xml.legacy |
Generalizes legacy PHPUnit config comment wording. |
phpunit.xml.dist |
Updates modern PHPUnit schema reference to 9.6. |
composer.json |
Bumps PHPUnit dev constraint, adds react/promise-timer, and reformats autoload blocks. |
.github/workflows/ci.yml |
Moves CI to Ubuntu 24.04, adjusts PHP matrix, updates checkout action, and reworks HHVM steps to use Docker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #39, #22, reactphp/socket#305 and others
Supersedes parts of #41/#40