chore(beat): remove non-existent refresh_compute_worker_health task#2411
Open
AybH26 wants to merge 2 commits into
Open
chore(beat): remove non-existent refresh_compute_worker_health task#2411AybH26 wants to merge 2 commits into
AybH26 wants to merge 2 commits into
Conversation
Member
|
Thank you for the PR and for following our guidelines. We'll review it as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2410
Context
CELERY_BEAT_SCHEDULEinsrc/settings/base.pycontained an entry that publishedcompetitions.tasks.refresh_compute_worker_healthevery 60s. That task does not exist anywhere in the codebase, so Beat was publishing a name the worker could not resolve.Effect
Repeated
NotRegistered/KeyErrorerrors on thesite_workerprefork consumer every minute. Log noise, and under certain conditions the consumer channel can be left in a broken state, blocking other tasks queued onsite-worker.Change
CELERY_BEAT_SCHEDULEinsrc/settings/base.py.How to verify
docker compose up site_worker.site_workerlogs for one minute.Received unregistered task of type 'competitions.tasks.refresh_compute_worker_health'(or equivalentKeyError) appears every ~60s.Risk
Minimal. The removed task was never executed (it does not exist), so no runtime behaviour depended on it.