Skip to content

made external http vars for endpoint configuration #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raphael-goetz merged 2 commits into from
Jun 12, 2026
Merged

made external http vars for endpoint configuration #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a01d6af
feat: made external http vars for endpoint configuration
raphael-goetz Jun 12, 2026
5bd2267
feat: made external use default vars if not present
raphael-goetz Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions adapter/rest/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,21 @@ use code0_flow::flow_config::env_with_default;
#[derive(Clone)]
pub struct HttpServerConfig {
pub port: u16,
pub external_port: u16,
pub host: String,
pub external_host: String,
}

impl LoadConfig for HttpServerConfig {
fn load() -> Self {
let port = env_with_default("HTTP_SERVER_PORT", 8080);
let host = env_with_default("HTTP_SERVER_HOST", String::from("127.0.0.1"));

Self {
port: env_with_default("HTTP_SERVER_PORT", 8080),
host: env_with_default("HTTP_SERVER_HOST", String::from("127.0.0.1")),
host: host.clone(),
port,
external_port: env_with_default("EXTERNAL_HTTP_SERVER_PORT", port),
external_host: env_with_default("EXTERNAL_HTTP_SERVER_HOST", host),
}
}
}
8 changes: 4 additions & 4 deletions adapter/rest/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,17 @@ async fn main() {
};
log::info!("Successfully created runner for http service");

let addr = runner.get_server_config().port;
let host = runner.get_server_config().host.clone();
let external_addr = runner.get_server_config().external_port;
let external_host = runner.get_server_config().external_host.clone();

let configs = vec![ModuleDefinitionAppendix {
module_identifier: String::from("draco-rest"),
definitions: vec![ModuleDefinition {
flow_type_identifier: vec![String::from("REST")],
value: Some(tucana::shared::module_definition::Value::Endpoint(
Endpoint {
host,
port: addr as i64,
host: external_host,
port: external_addr as i64,
endpoint: String::from(r"/${{project_slug}}${{httpURL}}"),
},
)),
Expand Down