Restore dfdally CI test config#251
Merged
caitlinross merged 3 commits intoJul 1, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
caitlinross
previously approved these changes
Jun 30, 2026
caitlinross
left a comment
caitlinross
left a comment
Member
There was a problem hiding this comment.
Looks good! Thanks! Just add in a separate config file with the director stuff and then you can merge!
caitlinross
force-pushed
the
fix-full-ci-dfdally-par
branch
from
cd19175 to
5c8ce93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared union MILC/Jacobi dfdally-72-par.conf.in test config
was changed to include ZeroMQ director-specific LPs and DIRECTOR
template variables. The existing full-dependency CI tests instantiate
this file with envsubst but do not define those director variables, so
the generated config contains empty values and the CI fails.
Restore this file to the original application/network surrogate test
configuration. Director-specific configs should live in a separate file
and be covered by a dedicated test.