perf(limiter): cache plans in memory instead of $lookup per workspace#556
Open
Kuchizu wants to merge 2 commits into
Open
perf(limiter): cache plans in memory instead of $lookup per workspace#556Kuchizu wants to merge 2 commits into
Kuchizu wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the limiter worker by caching tariff plans in memory at startup and resolving workspace plans without a MongoDB $lookup per workspace.
Changes:
- Adds plan collection wiring and startup cache loading in the limiter worker.
- Adds tariff plan cache helpers in
DbHelper. - Replaces workspace aggregation lookups with projected workspace reads plus in-memory plan resolution.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
workers/limiter/src/index.ts |
Initializes the plans collection, passes it to DbHelper, and loads plans during startup. |
workers/limiter/src/dbHelper.ts |
Adds plan caching and replaces $lookup aggregation with workspace projection plus cached plan resolution. |
workers/limiter/tests/dbHelper.test.ts |
Updates test setup to pass the plans collection and preload the plan cache. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
neSpecc
reviewed
May 27, 2026
Comment on lines
+221
to
+223
| if (!plan) { | ||
| this.knownMissingPlanIds.add(planIdStr); | ||
| } |
Member
There was a problem hiding this comment.
I think we need to refresh cache when there is no plan found in the cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache plans once at limiter startup (like paymaster) and resolve tariffPlan from memory instead of $lookup per workspace.