Skip to content

fix: replace raw echo with output helpers in general/stream#680

Merged
credfeto merged 1 commit into
mainfrom
fix/638-replace-raw-echo-in-general-stream
Jun 14, 2026
Merged

fix: replace raw echo with output helpers in general/stream#680
credfeto merged 1 commit into
mainfrom
fix/638-replace-raw-echo-in-general-stream

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the local die() function in general/stream with the standard output helpers (die, success, info) matching the project's shell-script conventions
  • The previous die() used bare echo calls; the new implementation uses printf with ANSI colour codes and writes to stderr
  • Trailing whitespace also removed by pre-commit hook

Closes #638

Test plan

  • shellcheck passes (verified via pre-commit hook)
  • Script behaviour preserved — die still exits non-zero with the streamer-not-specified message

@github-actions github-actions Bot added the auto-pr Pull request created automatically label Jun 14, 2026
@dnyw4l3n13 dnyw4l3n13 added AI-Work Work for an AI Agent Urgent Urgent Priority labels Jun 14, 2026
@dnyw4l3n13 dnyw4l3n13 marked this pull request as draft June 14, 2026 12:39
@credfeto credfeto marked this pull request as ready for review June 14, 2026 12:46
@credfeto credfeto marked this pull request as draft June 14, 2026 12:46
@dnyw4l3n13 dnyw4l3n13 marked this pull request as ready for review June 14, 2026 12:46
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

PR review complete. All checks passed and the implementation is correct:

  • die, success, and info helpers in general/stream match the reference implementations in shell-scripts.examples.md exactly
  • die correctly writes to stderr (>&2) and exits non-zero
  • Trailing whitespace removed from do line
  • CHANGELOG.md updated under the Unreleased section
  • All CI checks pass (build-pre-release, pull-request, Apply Template, Update Change Type Checkboxes)

No outstanding work — PR is ready for merge.

@credfeto

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

All CI checks pass and the PR has been approved. No outstanding work — the implementation is complete and ready for merge.

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Status report: All work on this PR is complete.

  • All CI checks pass (bash linting, changelog, build, no secrets, no merge conflicts, etc.)
  • PR approved by @credfeto
  • No outstanding review comments or actions needed
  • PR is ready for merge

Prompt: Replace raw echo with output helpers in `general/stream`

Closes #638
@dnyw4l3n13 dnyw4l3n13 force-pushed the fix/638-replace-raw-echo-in-general-stream branch from 2723840 to 8cf8f28 Compare June 14, 2026 13:32
@credfeto

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Status report: All work on this PR is complete.

  • All CI checks pass (bash linting, changelog, build, no secrets, no merge conflicts, etc.)
  • PR approved by @credfeto
  • PR is not in draft — ready for merge
  • No outstanding review comments or actions needed

@credfeto credfeto merged commit 41b52ef into main Jun 14, 2026
28 checks passed
@credfeto credfeto deleted the fix/638-replace-raw-echo-in-general-stream branch June 14, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Work Work for an AI Agent auto-pr Pull request created automatically Urgent Urgent Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace raw echo with output helpers in general/stream

2 participants