fix unnecessary casting and resulting clippy warning.#594
Closed
moritz-gross wants to merge 1 commit into
Closed
Conversation
type &'static str instead of String is ok.
Collaborator
Author
|
@NSoiffer some code you uncommented 2 commits ago causes |
Collaborator
|
Already fixed |
Collaborator
Author
|
wait, what am I missing? it's still failing in the latest commit. 
|
Collaborator
|
That's strange. I know I fixed it. Maybe I forgot to do a push? I made sure I did a push this time. In addition to fixing those warnings, there is some commented out code that contains the same problems. I fixed those also. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type
&'static strinstead ofStringis ok.