Release v1.1.1#23
Merged
Merged
Conversation
A non-sensitive or ignore discovery match carries no sensitivity label, but DiscoveryMatch required `label: str`, so parsing schema-discovery results that contained such a match (e.g. a scope.non_sensitive column, hit via the generate_ruleset path) raised a pydantic ValidationError. The schema_discovery CSV path never parsed the model, so this was latent until MongoDB document discovery exercised it.
Also fix comment re ignored matches - ignored matches don't get returned by the server at all
cph-datamasque
left a comment
cph-datamasque
left a comment
Collaborator
There was a problem hiding this comment.
please fix the content-type thing, looks good otherwise
cph-datamasque
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v1.1.1
Rolls up two bugfixes and one feature on top of 1.1.0, plus the version bump.
Changes
DiscoveryMatch.labelis now optional — it is absent for non-sensitive / ignore matches, which previously failed to parse.finished_with_warningsstatus toAsyncRulesetGenerationTaskStatus, and corrected a comment about ignored matches (the server doesn't return them at all).get_db_discovery_result_reportmay now returnbytes(a zip) when the server splits a large DB-discovery report; ruleset generation from CSV detects a zip payload and uploads it asruleset.zip.1.1.1(pyproject.toml,setup.cfg,uv.lock) and added theHISTORY.rstentry.Commits
fix: make DiscoveryMatch.label optional for non-sensitive/ignore matchesfeat: Add finished_with_warnings RG statusfeat: return split db-discovery reports as zip byteschore: release 1.1.1