Fix: detect handler methods inherited from base interfaces#11
Merged
Conversation
GetAllMethodsIncludingInherited only walked the BaseType chain, which is null for interfaces. Inherited interface members are exposed via AllInterfaces, so a handler method declared on a base interface was not detected and falsely triggered XPC4001. Also iterate AllInterfaces (transitive) so multi-level interface inheritance is covered. This fixes XPC4001, XPC4002, and the related code-fix providers, which all route through this helper. Co-Authored-By: Claude <noreply@anthropic.com> via Conducktor <conducktor@contextand.com>
There was a problem hiding this comment.
Pull request overview
Fixes analyzer/source-generator handler method discovery for interface inheritance by ensuring methods declared on base interfaces are detected (preventing false XPC4001/XPC4002 reports).
Changes:
- Update
TypeHelper.GetAllMethodsIncludingInheritedto also include methods fromAllInterfaces(transitive) to cover inherited interface members. - Add a diagnostic test ensuring XPC4001 is not reported when the handler method comes from a base interface.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| XrmPluginCore.SourceGenerator/Helpers/TypeHelper.cs | Extends method discovery to include inherited interface members via AllInterfaces. |
| XrmPluginCore.SourceGenerator.Tests/DiagnosticTests/DiagnosticReportingTests.cs | Adds coverage for handler methods inherited from a base interface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…evel chain - Only walk AllInterfaces when the input type is itself an interface, so FindImplementingMethods (called with class symbols) no longer surfaces unimplemented interface declaration methods. - Extend the regression test to a multi-level interface chain (ITestService : IMidService : IBaseService) to lock in the transitive AllInterfaces behavior. Co-Authored-By: Claude <noreply@anthropic.com> via Conducktor <conducktor@contextand.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetAllMethodsIncludingInherited only walked the BaseType chain, which is null for interfaces. Inherited interface members are exposed via AllInterfaces, so a handler method declared on a base interface was not detected and falsely triggered XPC4001.
Also iterate AllInterfaces (transitive) so multi-level interface inheritance is covered. This fixes XPC4001, XPC4002, and the related code-fix providers, which all route through this helper.