Document deployment.health + the no-poll failure loop#37
Merged
Conversation
notification-channels.md gains an "Asynchronous failures" section: when deployment.health fires (crash-loop/OOM/ImagePull auto-error, or deployer apply failure) vs the synchronous deployment.deploy failure, the system actor (empty actor), the non-secret reason-in-message convention, and that logs stay behind deployment.logs. monitoring.md gains "React to failures without polling" — the full me.generateToken → pull channel → notification.pull → deployment.status/logs loop, with recovery arriving on the same stream. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011d4bVuGLnCbcJD9ZvastPH
A PR preview that deploys green but then crash-loops or whose apply fails now updates its sticky comment to a failure state and flips the GitHub deployment status to failure (via the deployment.health signal), so a broken preview stops looking green. Production gets the status update, no comment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011d4bVuGLnCbcJD9ZvastPH
|
Preview deleted (PR closed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the failure-feedback feature (SPEC-failure-feedback.md §H).
Changes
deployment.healthfires (crash-loop/OOM/ImagePull auto-error, or deployer apply failure) vs the synchronousdeployment.deployfailure, the system actor (empty actor), the non-secret reason-in-messageconvention, and that full logs stay behinddeployment.logs.me.generateToken→ pull channel →notification.pull→deployment.status/logs), with recovery arriving on the same stream.Sequencing
The
deployment.healthevent (notification-channels + monitoring docs) ships with apiserver Part 1 (deploys-app/apiserver#174). The deploy-from-github post-deploy-failure note describes the Part 2 GitHub surface (deploys-app/apiserver#175) — merge this after Part 2 lands.Docs-only (Hugo markdown); CLI flags and internal links match existing pages.
🤖 Generated with Claude Code
https://claude.ai/code/session_011d4bVuGLnCbcJD9ZvastPH