Add Retry to Stream Errors#265
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds broader retry classification for transient transport-layer failures in ResilientOpenAIClient, aimed at improving resilience when OpenAI calls fail due to stream/connection issues (e.g., “Premature close”).
Changes:
- Refactors retry classification to detect network/transport failures via a new
hasRetriableNetworkSignal()helper that inspects errormessage/name/codeand followscausechains. - Keeps existing retry behavior for TIMEOUT (
ResilientOpenAIError) and HTTP status-based retriable errors (429 / 5xx). - Adds a regression test ensuring a
FetchErrorwith “Premature close” triggers a retry and succeeds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/backend/src/lib/resilientOpenAIClient.ts | Introduces hasRetriableNetworkSignal() and routes network/transport retry detection through it. |
| packages/backend/src/lib/resilientOpenAIClient.spec.ts | Adds test coverage for retrying transient “Premature close” fetch/stream failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.